Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in Dialect::supports_eq_alias_assigment #1478

Merged
merged 1 commit into from
Nov 6, 2024

Conversation

alamb
Copy link
Contributor

@alamb alamb commented Oct 21, 2024

I noticed this while reviewing other PRs. I think it is a small typo introduced in #1467

FYI @yoavcloud

@alamb alamb enabled auto-merge (squash) October 21, 2024 18:53
@alamb
Copy link
Contributor Author

alamb commented Oct 21, 2024

It appears that I can not merge this PR without at least one review from another DataFusion committer

@coveralls
Copy link

Pull Request Test Coverage Report for Build 11446672461

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 5 of 5 (100.0%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 89.392%

Totals Coverage Status
Change from base Build 11446585763: 0.0%
Covered Lines: 30497
Relevant Lines: 34116

💛 - Coveralls

@alamb
Copy link
Contributor Author

alamb commented Oct 21, 2024

Screenshot 2024-10-21 at 2 56 05 PM

@alamb alamb requested a review from andygrove October 21, 2024 19:45
@yoavcloud
Copy link
Contributor

Thanks!

Copy link
Contributor

@iffyio iffyio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah thanks for catching and fixing this @alamb! LGTM!

@alamb
Copy link
Contributor Author

alamb commented Oct 26, 2024

🤔 something is not working with permissions and I can't merge PRs anymore (I think it is because someone else with write access needs to approve the PR):

Screenshot 2024-10-26 at 7 15 39 AM

I think this changed in #1463 from @Xuanwo -- I will try and sort it out

@alamb alamb merged commit a9a9d58 into apache:main Nov 6, 2024
10 checks passed
@alamb alamb deleted the alamb/fix_typo branch November 6, 2024 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants