Skip to content

Conversation

mvzink
Copy link
Contributor

@mvzink mvzink commented Feb 19, 2025

This allows preserving the orderings of column options.

We also no longer hardcode a list of dialects which accept a column collation, as it's part of the SQL standard and some dialects which do support it were missing from the list (e.g. MSSQL).

@mvzink mvzink marked this pull request as draft February 19, 2025 22:16
This allows preserving the orderings of column options.

We also no longer hardcode a list of dialects which accept a column
collation, as it's part of the SQL standard and some dialects which do
support it were missing from the list.
@mvzink mvzink marked this pull request as ready for review February 19, 2025 22:19
Copy link
Contributor

@iffyio iffyio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @mvzink!
cc @alamb

@iffyio iffyio merged commit 97f0be6 into apache:main Feb 20, 2025
9 checks passed
ayman-sigma pushed a commit to sigmacomputing/sqlparser-rs that referenced this pull request Apr 10, 2025
@mvzink mvzink deleted the push-nkpmkvkurnuw branch June 20, 2025 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants