Miscellaneous fixes #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove `pub` from the "internal" ones. Remove ones that duplicate each other completely.
1) Simplified the bit in parse_datatype() 2) Made sure it was covered by the test (the "public.year" bit) 2a) ...the rest of changes in the test are to fix incorrect variable names: c_name/c_lat/c_lng were copy-pasted from a previous test. 3) Removed the branch from parse_pg_cast, which duplicated what parse_data_type already handled (added in the same commit even andygrove@2007995 )
...it gets handled just as well by the infix parser. (Add a test while we're at it.)
…re of in parse_infix()
There's no Token::Period in such situation, so fractional part (from sec) was silently truncated. Can't uncomment the test yet, because parse_timestamp() is effectively unused: the code added to parse_value() in 5abd9e7 was wrong as it attempted to handle unquoted date/time literals. One part of it was commented out earlier, the other can't work as far as I can see, as it tries to parse a Number token - `([0-9]|\.)+` - as a timestamp, so I removed it as well.
|
The CI failure is due to rust-lang/rust#57488... |
andygrove
approved these changes
Jan 11, 2019
Pull Request Test Coverage Report for Build 91
💛 - Coveralls |
|
Merged! Thanks @nickolay |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are a few unrelated fixes I came up with while reading through the code. See the commit messages for more details about each one.
I added tests where there wasn't sufficient coverage, except for timestamps where the code being fixed is effectively unused at this moment, since we don't have the code to handle
TIMESTAMP '...'literals.