add cast support inside values() (#3447)

apache · Sep 12, 2022 · 3e56a0f · 3e56a0f
1 parent c5c1dae
commit 3e56a0f
Show file tree

Hide file tree

Showing 2 changed files with 36 additions and 0 deletions.
diff --git a/datafusion/core/tests/sql/select.rs b/datafusion/core/tests/sql/select.rs
@@ -244,6 +244,34 @@ async fn select_values_list() -> Result<()> {
         ];
         assert_batches_eq!(expected, &actual);
     }
+    {
+        let sql = "EXPLAIN VALUES ('1'::float)";
+        let actual = execute_to_batches(&ctx, sql).await;
+        let expected = vec![
+            "+---------------+-----------------------------------+",
+            "| plan_type     | plan                              |",
+            "+---------------+-----------------------------------+",
+            "| logical_plan  | Values: (Float32(1) AS Utf8(\"1\")) |",
+            "| physical_plan | ValuesExec                        |",
+            "|               |                                   |",
+            "+---------------+-----------------------------------+",
+        ];
+        assert_batches_eq!(expected, &actual);
+    }
+    {
+        let sql = "EXPLAIN VALUES (('1'||'2')::int unsigned)";
+        let actual = execute_to_batches(&ctx, sql).await;
+        let expected = vec![
+            "+---------------+------------------------------------------------+",
+            "| plan_type     | plan                                           |",
+            "+---------------+------------------------------------------------+",
+            "| logical_plan  | Values: (UInt32(12) AS Utf8(\"1\") || Utf8(\"2\")) |",
+            "| physical_plan | ValuesExec                                     |",
+            "|               |                                                |",
+            "+---------------+------------------------------------------------+",
+        ];
+        assert_batches_eq!(expected, &actual);
+    }
     Ok(())
 }
 

diff --git a/datafusion/sql/src/planner.rs b/datafusion/sql/src/planner.rs
@@ -1683,6 +1683,14 @@ impl<'a, S: ContextProvider> SqlToRel<'a, S> {
                             expr: Box::new(lit(value)),
                             data_type: convert_data_type(&data_type)?,
                         }),
+                        SQLExpr::Cast { expr, data_type } => Ok(Expr::Cast {
+                            expr: Box::new(self.sql_expr_to_logical_expr(
+                                *expr,
+                                &schema,
+                                &mut HashMap::new(),
+                            )?),
+                            data_type: convert_data_type(&data_type)?,
+                        }),
                         other => Err(DataFusionError::NotImplemented(format!(
                             "Unsupported value {:?} in a values list expression",
                             other