Skip to content

Commit

Permalink
Minor: Run ScalarValue size test on aarch again (#9728)
Browse files Browse the repository at this point in the history
* Minor: Run ScalarValue size test on aarch again

* add comments
  • Loading branch information
alamb authored Mar 22, 2024
1 parent 2b69acc commit 47f4b5a
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions datafusion/common/src/scalar/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -4528,18 +4528,18 @@ mod tests {
assert_eq!(expected, data_type.try_into().unwrap())
}

// this test fails on aarch, so don't run it there
#[cfg(not(target_arch = "aarch64"))]
#[test]
fn size_of_scalar() {
// Since ScalarValues are used in a non trivial number of places,
// making it larger means significant more memory consumption
// per distinct value.
//
// Thus this test ensures that no code change makes ScalarValue larger
//
// The alignment requirements differ across architectures and
// thus the size of the enum appears to as well

// The value can be changed depending on rust version
// The value may also change depending on rust version
assert_eq!(std::mem::size_of::<ScalarValue>(), 64);
}

Expand Down

0 comments on commit 47f4b5a

Please sign in to comment.