Skip to content

Commit

Permalink
Add upstream ticket reference (#7275)
Browse files Browse the repository at this point in the history
Add doc link reference to apache/arrow-rs#4693
  • Loading branch information
alamb authored Aug 13, 2023
1 parent 0ad6473 commit 563a1dc
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions datafusion/core/src/datasource/file_format/parquet.rs
Original file line number Diff line number Diff line change
Expand Up @@ -604,6 +604,7 @@ impl DisplayAs for ParquetSink {
}

/// Parses datafusion.execution.parquet.encoding String to a parquet::basic::Encoding
/// TODO use upstream version: <https://github.com/apache/arrow-rs/issues/4693>
fn parse_encoding_string(str_setting: &str) -> Result<parquet::basic::Encoding> {
let str_setting_lower: &str = &str_setting.to_lowercase();
match str_setting_lower {
Expand Down Expand Up @@ -667,6 +668,7 @@ fn require_level(codec: &str, level: Option<u32>) -> Result<u32> {
}

/// Parses datafusion.execution.parquet.compression String to a parquet::basic::Compression
/// TODO use upstream version: <https://github.com/apache/arrow-rs/issues/4693>
fn parse_compression_string(str_setting: &str) -> Result<parquet::basic::Compression> {
let str_setting_lower: &str = &str_setting.to_lowercase();
let (codec, level) = split_compression_string(str_setting_lower)?;
Expand Down Expand Up @@ -717,6 +719,7 @@ fn parse_compression_string(str_setting: &str) -> Result<parquet::basic::Compres
}
}

/// TODO use upstream version: <https://github.com/apache/arrow-rs/issues/4693>
fn parse_version_string(str_setting: &str) -> Result<WriterVersion> {
let str_setting_lower: &str = &str_setting.to_lowercase();
match str_setting_lower {
Expand All @@ -729,6 +732,7 @@ fn parse_version_string(str_setting: &str) -> Result<WriterVersion> {
}
}

/// TODO use upstream version: <https://github.com/apache/arrow-rs/issues/4693>
fn parse_statistics_string(str_setting: &str) -> Result<EnabledStatistics> {
let str_setting_lower: &str = &str_setting.to_lowercase();
match str_setting_lower {
Expand Down

0 comments on commit 563a1dc

Please sign in to comment.