[branch-51] bugfix: correct regression on TableType in into_view in DF51 (#18618)

This is the same as #18617 but
targeted at the DF-51 release branch

Author: timsaucer

datafusion/core/src/dataframe/mod.rs

@@ -1655,7 +1655,7 @@ impl DataFrame {
     pub fn into_view(self) -> Arc<dyn TableProvider> {
         Arc::new(DataFrameTableProvider {
             plan: self.plan,
-            table_type: TableType::Temporary,
+            table_type: TableType::View,
         })
     }
 

datafusion/core/tests/dataframe/mod.rs

@@ -1627,7 +1627,9 @@ async fn register_table() -> Result<()> {
     let df_impl = DataFrame::new(ctx.state(), df.logical_plan().clone());
 
     // register a dataframe as a table
-    ctx.register_table("test_table", df_impl.clone().into_view())?;
+    let table_provider = df_impl.clone().into_view();
+    assert_eq!(table_provider.table_type(), TableType::View);
+    ctx.register_table("test_table", table_provider)?;
 
     // pull the table out
     let table = ctx.table("test_table").await?;