bugfix: correct regression on TableType for into_view #18617
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timsaucer
changed the title
Member
Author
|
@r1b mind a quick review? One line change to the code, plus unit test |
Jefffrey
approved these changes
Nov 11, 2025
alamb
approved these changes
Nov 11, 2025
Contributor
alamb
left a comment
alamb
left a comment
There was a problem hiding this comment.
Makes sense to me -- thanks @timsaucer
viirya
approved these changes
Nov 11, 2025
viirya
reviewed
Nov 11, 2025
Comment on lines
+1630
to
+1632
| let table_provider = df_impl.clone().into_view(); | ||
| assert_eq!(table_provider.table_type(), TableType::View); | ||
| ctx.register_table("test_table", table_provider)?; |
Member
There was a problem hiding this comment.
This TableType::View assert is the only one test check for into_view and it is in a test that looks like not added particularly for it. That's said it is very possible it will be forgotten easily.
Maybe just add a simple test specific for into_view?
Contributor
|
Thanks @timsaucer @viirya and @Jefffrey -- great call to add a test |
Contributor
|
Thank you @timsaucer |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
#18158 introduced a regression in the table type created with
DataFrame::into_view()Rationale for this change
Correct regression
What changes are included in this PR?
One line fix
Are these changes tested?
Unit test added
Are there any user-facing changes?
None