make datafusion-proto match exhaustive (#2567)

apache · May 18, 2022 · 635d659 · 635d659
1 parent 78207f5
commit 635d659
Showing 1 changed file with 9 additions and 1 deletion.
diff --git a/datafusion/proto/src/to_proto.rs b/datafusion/proto/src/to_proto.rs
@@ -713,7 +713,15 @@ impl TryFrom<&Expr> for protobuf::LogicalExprNode {
             Expr::Wildcard => Self {
                 expr_type: Some(ExprType::Wildcard(true)),
             },
-            _ => unimplemented!(),
+            Expr::ScalarSubquery(_) | Expr::InSubquery { .. } | Expr::Exists { .. } => {
+                // we would need to add logical plan operators to datafusion.proto to support this
+                // see discussion in https://github.com/apache/arrow-datafusion/issues/2565
+                unimplemented!("subquery expressions are not supported yet")
+            }
+            Expr::QualifiedWildcard { .. }
+            | Expr::GetIndexedField { .. }
+            | Expr::TryCast { .. }
+            | Expr::GroupingSet(_) => unimplemented!(),
         };
 
         Ok(expr_node)