Skip to content

Commit 9c116a5

Browse files
authored
ci: fix temporary file creation in tests and tighten CI check (#18374)
## Which issue does this PR close? <!-- We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123. --> - Closes #. ## Rationale for this change <!-- Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed. Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes. --> Temporary file is created during test, see reproducer in `datafusion-cli` ```sh yongting@Yongtings-MacBook-Pro-2 ~/C/datafusion (main=)> cargo test --package datafusion --test core_integration --all-features -- dataframe::test_copy_schema --exact --nocapture Compiling datafusion v50.3.0 (/Users/yongting/Code/datafusion/datafusion/core) Finished `test` profile [unoptimized + debuginfo] target(s) in 2.50s Running tests/core_integration.rs (target/debug/deps/core_integration-dee3896b38f536b2) running 1 test test dataframe::test_copy_schema ... ok test result: ok. 1 passed; 0 failed; 0 ignored; 0 measured; 801 filtered out; finished in 0.02s yongting@Yongtings-MacBook-Pro-2 ~/C/datafusion (main=)> git status On branch main Your branch is up to date with 'upstream/main'. Untracked files: (use "git add <file>..." to include in what will be committed) "datafusion/core/\"/" nothing added to commit but untracked files present (use "git add" to track) ``` This PR fixes this test, and make CI stricter for similar temporary file creations. ## What changes are included in this PR? <!-- There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR. --> ## Are these changes tested? <!-- We typically require tests for all PRs in order to: 1. Prevent the code from being accidentally broken by subsequent changes 2. Serve as another way to document the expected behavior of the code If tests are not included in your PR, please explain why (for example, are they covered by existing tests)? --> Yes, I have run the CI without fix in my local repo, it's failing as expected: https://github.com/2010YOUY01/arrow-datafusion/actions/runs/18913128118/job/53989721867 After the fix, the CI should be able to pass. ## Are there any user-facing changes? <!-- If there are user-facing changes then we may require documentation to be updated before approving the PR. --> <!-- If there are any breaking changes to public APIs, please add the `api change` label. -->
1 parent 9e9eb94 commit 9c116a5

File tree

2 files changed

+10
-1
lines changed

2 files changed

+10
-1
lines changed

.github/workflows/rust.yml

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -302,6 +302,15 @@ jobs:
302302
--features serde,avro,json,backtrace,integration-tests,parquet_encryption
303303
- name: Verify Working Directory Clean
304304
run: git diff --exit-code
305+
# Check no temporary directories created during test.
306+
# `false/` folder is excuded for rust cache.
307+
- name: Verify Working Directory Clean (No Untracked Files)
308+
run: |
309+
STATUS="$(git status --porcelain | sed -e '/^?? false\/$/d' -e '/^?? false$/d')"
310+
if [ -n "$STATUS" ]; then
311+
echo "$STATUS"
312+
exit 1
313+
fi
305314
306315
# datafusion-cli tests
307316
linux-test-datafusion-cli:

datafusion/core/tests/dataframe/mod.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6328,7 +6328,7 @@ async fn test_copy_schema() -> Result<()> {
63286328
let target_path = tmp_dir.path().join("target.csv");
63296329

63306330
let query = format!(
6331-
"COPY source_table TO '{:?}' STORED AS csv",
6331+
"COPY source_table TO '{}' STORED AS csv",
63326332
target_path.to_str().unwrap()
63336333
);
63346334

0 commit comments

Comments
 (0)