ci: fix temporary file creation in tests and tighten CI check #18374
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
development-process
2010YOUY01
commented
Oct 30, 2025
|
|
||
| let query = format!( | ||
| "COPY source_table TO '{:?}' STORED AS csv", | ||
| "COPY source_table TO '{}' STORED AS csv", |
Contributor
Author
There was a problem hiding this comment.
Debug display with '{:?}' will make the path look like "/foo/bar", and " is treated as a directory name.
Jefffrey
approved these changes
Oct 30, 2025
Contributor
Author
|
Thanks for the review! |
tobixdev
pushed a commit
to tobixdev/datafusion
that referenced
this pull request
Nov 2, 2025
…#18374) ## Which issue does this PR close? <!-- We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes apache#123` indicates that this PR will close issue apache#123. --> - Closes #. ## Rationale for this change <!-- Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed. Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes. --> Temporary file is created during test, see reproducer in `datafusion-cli` ```sh yongting@Yongtings-MacBook-Pro-2 ~/C/datafusion (main=)> cargo test --package datafusion --test core_integration --all-features -- dataframe::test_copy_schema --exact --nocapture Compiling datafusion v50.3.0 (/Users/yongting/Code/datafusion/datafusion/core) Finished `test` profile [unoptimized + debuginfo] target(s) in 2.50s Running tests/core_integration.rs (target/debug/deps/core_integration-dee3896b38f536b2) running 1 test test dataframe::test_copy_schema ... ok test result: ok. 1 passed; 0 failed; 0 ignored; 0 measured; 801 filtered out; finished in 0.02s yongting@Yongtings-MacBook-Pro-2 ~/C/datafusion (main=)> git status On branch main Your branch is up to date with 'upstream/main'. Untracked files: (use "git add <file>..." to include in what will be committed) "datafusion/core/\"/" nothing added to commit but untracked files present (use "git add" to track) ``` This PR fixes this test, and make CI stricter for similar temporary file creations. ## What changes are included in this PR? <!-- There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR. --> ## Are these changes tested? <!-- We typically require tests for all PRs in order to: 1. Prevent the code from being accidentally broken by subsequent changes 2. Serve as another way to document the expected behavior of the code If tests are not included in your PR, please explain why (for example, are they covered by existing tests)? --> Yes, I have run the CI without fix in my local repo, it's failing as expected: https://github.com/2010YOUY01/arrow-datafusion/actions/runs/18913128118/job/53989721867 After the fix, the CI should be able to pass. ## Are there any user-facing changes? <!-- If there are user-facing changes then we may require documentation to be updated before approving the PR. --> <!-- If there are any breaking changes to public APIs, please add the `api change` label. -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
Temporary file is created during test, see reproducer in
datafusion-cliThis PR fixes this test, and make CI stricter for similar temporary file creations.
What changes are included in this PR?
Are these changes tested?
Yes, I have run the CI without fix in my local repo, it's failing as expected: https://github.com/2010YOUY01/arrow-datafusion/actions/runs/18913128118/job/53989721867
After the fix, the CI should be able to pass.
Are there any user-facing changes?