Actually test that ScalarValues are the same after round trip seria…

…lization (#3537)
apache · Sep 20, 2022 · e873423 · e873423
1 parent 4b1e044
commit e873423
Showing 1 changed file with 11 additions and 2 deletions.
diff --git a/datafusion/proto/src/lib.rs b/datafusion/proto/src/lib.rs
@@ -465,8 +465,17 @@ mod roundtrip_tests {
             let proto: super::protobuf::ScalarValue = (&test_case)
                 .try_into()
                 .expect("failed conversion to protobuf");
-            let _roundtrip: ScalarValue =
-                (&proto).try_into().expect("failed conversion to protobuf");
+
+            let roundtrip: ScalarValue = (&proto)
+                .try_into()
+                .expect("failed conversion from protobuf");
+
+            assert_eq!(
+                test_case, roundtrip,
+                "ScalarValue was not the same after round trip!\n\n\
+                        Input: {:?}\n\nRoundtrip: {:?}",
+                test_case, roundtrip
+            );
         }
     }