Skip to content

Commit eb4f852

Browse files
authored
Remove parquet_filter and parquet sort benchmarks (#16730)
* Remove parquet_filter and parquet_sort benchmarks * Remove more
1 parent 8d7b11b commit eb4f852

File tree

8 files changed

+1
-547
lines changed

8 files changed

+1
-547
lines changed

benchmarks/bench.sh

Lines changed: 0 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -114,8 +114,6 @@ imdb: Join Order Benchmark (JOB) using the IMDB dataset conver
114114
115115
# Micro-Benchmarks (specific operators and features)
116116
cancellation: How long cancelling a query takes
117-
parquet: Benchmark of parquet reader's filtering speed
118-
sort: Benchmark of sorting speed
119117
120118
━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
121119
Supported Configuration (Environment Variables)
@@ -303,8 +301,6 @@ main() {
303301
run_tpch "10" "csv"
304302
run_tpch_mem "10"
305303
run_cancellation
306-
run_parquet
307-
run_sort
308304
run_clickbench_1
309305
run_clickbench_partitioned
310306
run_clickbench_extended
@@ -338,12 +334,6 @@ main() {
338334
cancellation)
339335
run_cancellation
340336
;;
341-
parquet)
342-
run_parquet
343-
;;
344-
sort)
345-
run_sort
346-
;;
347337
clickbench_1)
348338
run_clickbench_1
349339
;;
@@ -528,22 +518,6 @@ run_cancellation() {
528518
debug_run $CARGO_COMMAND --bin dfbench -- cancellation --iterations 5 --path "${DATA_DIR}/cancellation" -o "${RESULTS_FILE}"
529519
}
530520

531-
# Runs the parquet filter benchmark
532-
run_parquet() {
533-
RESULTS_FILE="${RESULTS_DIR}/parquet.json"
534-
echo "RESULTS_FILE: ${RESULTS_FILE}"
535-
echo "Running parquet filter benchmark..."
536-
debug_run $CARGO_COMMAND --bin parquet -- filter --path "${DATA_DIR}" --scale-factor 1.0 --iterations 5 -o "${RESULTS_FILE}"
537-
}
538-
539-
# Runs the sort benchmark
540-
run_sort() {
541-
RESULTS_FILE="${RESULTS_DIR}/sort.json"
542-
echo "RESULTS_FILE: ${RESULTS_FILE}"
543-
echo "Running sort benchmark..."
544-
debug_run $CARGO_COMMAND --bin parquet -- sort --path "${DATA_DIR}" --scale-factor 1.0 --iterations 5 -o "${RESULTS_FILE}"
545-
}
546-
547521

548522
# Downloads the single file hits.parquet ClickBench datasets from
549523
# https://github.com/ClickHouse/ClickBench/tree/main#data-loading

benchmarks/src/bin/dfbench.rs

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -33,9 +33,7 @@ static ALLOC: snmalloc_rs::SnMalloc = snmalloc_rs::SnMalloc;
3333
#[global_allocator]
3434
static ALLOC: mimalloc::MiMalloc = mimalloc::MiMalloc;
3535

36-
use datafusion_benchmarks::{
37-
cancellation, clickbench, h2o, imdb, parquet_filter, sort, sort_tpch, tpch,
38-
};
36+
use datafusion_benchmarks::{cancellation, clickbench, h2o, imdb, sort_tpch, tpch};
3937

4038
#[derive(Debug, StructOpt)]
4139
#[structopt(about = "benchmark command")]
@@ -44,8 +42,6 @@ enum Options {
4442
Clickbench(clickbench::RunOpt),
4543
H2o(h2o::RunOpt),
4644
Imdb(imdb::RunOpt),
47-
ParquetFilter(parquet_filter::RunOpt),
48-
Sort(sort::RunOpt),
4945
SortTpch(sort_tpch::RunOpt),
5046
Tpch(tpch::RunOpt),
5147
TpchConvert(tpch::ConvertOpt),
@@ -61,8 +57,6 @@ pub async fn main() -> Result<()> {
6157
Options::Clickbench(opt) => opt.run().await,
6258
Options::H2o(opt) => opt.run().await,
6359
Options::Imdb(opt) => Box::pin(opt.run()).await,
64-
Options::ParquetFilter(opt) => opt.run().await,
65-
Options::Sort(opt) => opt.run().await,
6660
Options::SortTpch(opt) => opt.run().await,
6761
Options::Tpch(opt) => Box::pin(opt.run()).await,
6862
Options::TpchConvert(opt) => opt.run().await,

benchmarks/src/bin/parquet.rs

Lines changed: 0 additions & 49 deletions
This file was deleted.

benchmarks/src/lib.rs

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,8 +20,6 @@ pub mod cancellation;
2020
pub mod clickbench;
2121
pub mod h2o;
2222
pub mod imdb;
23-
pub mod parquet_filter;
24-
pub mod sort;
2523
pub mod sort_tpch;
2624
pub mod tpch;
2725
pub mod util;

benchmarks/src/parquet_filter.rs

Lines changed: 0 additions & 194 deletions
This file was deleted.

0 commit comments

Comments
 (0)