Skip to content

Conversation

@alamb
Copy link
Contributor

@alamb alamb commented Jul 9, 2025

Which issue does this PR close?

Rationale for this change

These benchmarks are not used, and are done against synthetic data, and do not seem to measure the impact of filter pushdown or sort in a meaningful way. See additional rationale here:

  1. To test filter pushdown we use the clickbench queries
  2. To test sorting we use the sort_tpch benchmark

Also the name parquet as the benchmark is misleading as it is supposed to be for parquet filter pushdown

For example of this test adding #16711 (comment)

Let's remove these benchmarks and make a new one using the clickbench queries and data

What changes are included in this PR?

  1. remove two unused benchmarks

Are these changes tested?

By CI and I tested that bench.sh still works

Are there any user-facing changes?

No (as I don't think these were ever used)

@alamb alamb changed the title Remove parquet_filter and parquet_sort benchmarks Remove parquet_filter and parquet sort benchmarks Jul 9, 2025
Copy link
Member

@xudong963 xudong963 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹

@alamb
Copy link
Contributor Author

alamb commented Jul 11, 2025

Thank you for the review @xudong963

@alamb alamb merged commit eb4f852 into apache:main Jul 11, 2025
49 of 50 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants