-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stop copying LogicalPlan and Exprs in EliminateFilter
#10288
Labels
good first issue
Good for newcomers
Comments
31 tasks
demetribu
added a commit
to demetribu/datafusion
that referenced
this issue
Apr 29, 2024
demetribu
added a commit
to demetribu/datafusion
that referenced
this issue
Apr 30, 2024
demetribu
added a commit
to demetribu/datafusion
that referenced
this issue
Apr 30, 2024
demetribu
added a commit
to demetribu/datafusion
that referenced
this issue
Apr 30, 2024
demetribu
added a commit
to demetribu/datafusion
that referenced
this issue
Apr 30, 2024
alamb
pushed a commit
that referenced
this issue
Apr 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Is your feature request related to a problem or challenge?
Part of #9637
As part of making the planner faster, we are updating the optimizer passes to avoid copying
LogicalPlan
andExpr
(see #9637)Describe the solution you'd like
I would like to reduce the amount of copying in this pass (even though it doesn't appear in current profiling)
Describe alternatives you've considered
Apply the model from @Lordworms in #10166 to this pass
2. Update OptimizerRule::supports_rewrite` to return true
OptimizerRule
to userewrite
TreeNode
API) - it is implemented forLogicalPlan
(API) andExpr
(API)Other examples: #10218
Additional context
I think this will be a pretty simple refactor with a good existing pattern, so mark this as good first issue
The text was updated successfully, but these errors were encountered: