Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate LogicalPlan::CrossJoin #13057

Closed
Dandandan opened this issue Oct 22, 2024 · 4 comments · Fixed by #13076
Closed

Deprecate LogicalPlan::CrossJoin #13057

Dandandan opened this issue Oct 22, 2024 · 4 comments · Fixed by #13076
Assignees
@buraksenn
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@Dandandan
Copy link
Contributor

Is your feature request related to a problem or challenge?

After #12985 we don't generate LogicalPlan::CrossJoin in the planner.
It would be good to deprecate / remove this in the future.

Describe the solution you'd like

No response

Describe alternatives you've considered

No response

Additional context

No response
@Dandandan Dandandan added the enhancement New feature or request label Oct 22, 2024
@Dandandan Dandandan changed the title Fully remove LogicalPlan::CrossJoin Deprecate LogicalPlan::CrossJoin Oct 22, 2024
@Dandandan Dandandan added the good first issue Good for newcomers label Oct 22, 2024
@ding-young
Copy link
Contributor

take

@buraksenn buraksenn mentioned this issue Oct 23, 2024
Merged
@buraksenn
Copy link
Contributor

Sorry @ding-young , I've already started working on this before typing take and just opened a PR.

@ding-young ding-young removed their assignment Oct 23, 2024
@ding-young
Copy link
Contributor

@buraksenn Ohh I see. Thank you for letting me know.

@buraksenn
Copy link
Contributor

take

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@buraksenn buraksenn

Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove unused LogicalPlan::CrossJoin as it is unused buraksenn/datafusion
3 participants
@Dandandan @ding-young @buraksenn