Remove unused LogicalPlan::CrossJoin as it is unused
#13076
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
sql
alamb
changed the title
LogicalPlan::CrossJoin as it is unused
alamb
approved these changes
Oct 24, 2024
There was a problem hiding this comment.
THank you @buraksenn -- this looks like a very nice cleanup to me
cc @Dandandan who has been working in this area recently as well
| @@ -220,10 +220,6 @@ pub enum LogicalPlan { | |||
| /// Join two logical plans on one or more join columns. | |||
| /// This is used to implement SQL `JOIN` | |||
| Join(Join), | |||
| /// Apply Cross Join to two logical plans. | |||
| /// This is used to implement SQL `CROSS JOIN` | |||
| /// Deprecated: use [LogicalPlan::Join] instead with empty `on` / no filter | |||
There was a problem hiding this comment.
nice for cleaning up a deprecated feature
Michael-J-Ward
added a commit
to Michael-J-Ward/datafusion-python
that referenced
this pull request
Oct 28, 2024
It was removed upstream. Ref: apache/datafusion#13076
3 tasks
Michael-J-Ward
added a commit
to apache/datafusion-python
that referenced
this pull request
Nov 10, 2024
* patch datafusion deps * migrate from deprecated RuntimeEnv::new to RuntimeEnv::try_new Ref: apache/datafusion#12566 * remove Arc from create_udf call Ref: apache/datafusion#12489 * doc typo * migrage new UnnestOptions API Ref: https://github.com/apache/datafusion/pull/12836/files * update API for logical expr Limit Ref: apache/datafusion#12836 * remove logical expr CrossJoin It was removed upstream. Ref: apache/datafusion#13076 * update PyWindowUDF Ref: apache/datafusion#12803 * migrate window functions lead and lag to udwf Ref: apache/datafusion#12802 * migrate window functions rank, dense_rank, and percent_rank to udwf Ref: apache/datafusion#12648 * convert window function cume_dist to udwf Ref: apache/datafusion#12695 * convert window function ntile to udwf Ref: apache/datafusion#12694 * clean up functions_window invocation * Only one column was being passed to udwf * Update to DF 43.0.0 * Update tests to look for string_view type * String view is now the default type for strings * Making a variety of adjustments in wrappers and unit tests to account for the switch from string to string_view as default * Resolve errors in doc building --------- Co-authored-by: Tim Saucer <timsaucer@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #13057
Rationale for this change
LogicalPlan::CrossJoin is not generated anymore so deleted all of its occurences
What changes are included in this PR?
Are these changes tested?
Existing tests
Are there any user-facing changes?
no