Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for Utf8View to array_to_string, string_to_array functions #13383

Closed
Omega359 opened this issue Nov 12, 2024 · 1 comment · Fixed by #13403
Closed

Add support for Utf8View to array_to_string, string_to_array functions #13383

Omega359 opened this issue Nov 12, 2024 · 1 comment · Fixed by #13403
Assignees
@Omega359
Labels
enhancement New feature or request

Comments

@Omega359
Copy link
Contributor

Omega359 commented Nov 12, 2024 •
edited
Loading

Is your feature request related to a problem or challenge?

Currently the array_to_string and string_to_array functions do not directly support Utf8View type but rather casts it to Utf8. It would be good to support Utf8View directly

Describe the solution you'd like

array_to_string and string_to_array functions supports Utf8View directly without casts.

Describe alternatives you've considered

Leave as is.

Additional context

No response
@Omega359 Omega359 added the enhancement New feature or request label Nov 12, 2024
@Omega359
Copy link
Contributor Author

take

@Omega359 Omega359 changed the title Add support for Utf8View to array_to_string function Add support for Utf8View to array_to_string, string_to_array functions Nov 12, 2024
@Omega359 Omega359 mentioned this issue Nov 13, 2024
Merged
Omega359 added a commit to Omega359/arrow-datafusion that referenced this issue Nov 14, 2024
@Omega359
Directly support utf8view in array_to_string & string_to_array. apach…
db18086 
…e#13383
@Omega359 Omega359 mentioned this issue Nov 14, 2024
Merged
alamb pushed a commit that referenced this issue Nov 21, 2024
@Omega359
Add support for Utf8View to string_to_array and array_to_string (#13403)
dd4fa79 
* Directly support utf8view in array_to_string & string_to_array. #13383

* Update to have output data type match input data type.

* Return type cleanup.

* Updated to properly handle returning largeutf8 + code refactor and a few more tests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Omega359 Omega359

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add support for Utf8View to string_to_array and array_to_string Omega359/arrow-datafusion
1 participant
@Omega359