-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Closed
Labels
enhancementNew feature or requestNew feature or requestgood first issueGood for newcomersGood for newcomersperformanceMake DataFusion fasterMake DataFusion faster
Description
Is your feature request related to a problem or challenge?
While reviewing #14575 from @wForget I noticed that the implementation of repeat
could be better
Specifically, it calls String::repeat which allocates and copies the string (before append_value copies it again)
Describe the solution you'd like
I think we could avoid the allocation (aka the call to String::repeat
)
Describe alternatives you've considered
I think we could avoid the copy using the Write
implementation as explained on
Additional context
No response
wForgetcomphead
Metadata
Metadata
Assignees
Labels
enhancementNew feature or requestNew feature or requestgood first issueGood for newcomersGood for newcomersperformanceMake DataFusion fasterMake DataFusion faster