Skip to content

Add test coverage for wasm32 + parquet build #15158

@alamb

Description

@alamb

Is your feature request related to a problem or challenge?

We do have a very nice wasmtest test to make sure datafusion is buildable with wasmpack (thanks @jonmmease !):

linux-wasm-pack:
name: build with wasm-pack
runs-on: ubuntu-latest
container:
image: amd64/rust
steps:
- uses: actions/checkout@v4
- name: Setup Rust toolchain
uses: ./.github/actions/setup-builder
with:
rust-version: stable
- name: Install wasm-pack
run: curl https://rustwasm.github.io/wasm-pack/installer/init.sh -sSf | sh
- name: Build with wasm-pack
working-directory: ./datafusion/wasmtest
run: wasm-pack build --dev

However, As discussed here, that test doesn't use parquet and thus we broke parquet compilation

@XiangpengHao added the feature flag to the build in #1510 but wasmtest doesn't actually do anythign with parquet. So the flag could be removed accidentally in the future and all tests would still pass

Describe the solution you'd like

I would like to extend the wasmtest binary to actually something with parquet via wasm (not just adding the feature flag as in this PR)

Perhaps it could just open a parquet file, or try writing one into memory

Describe alternatives you've considered

No response

Additional context

No response

Metadata

Metadata

Labels

enhancementNew feature or request

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions