-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Closed
Labels
good first issueGood for newcomersGood for newcomers
Description
In #15178, we're switching hard-coded constants in tests to insta.
This issue targets updating user_defined (datafusion/core/tests/user_defined
).
Examples of tests that need to be switched to insta
datafusion/datafusion/core/tests/user_defined/expr_planner.rs
Lines 79 to 85 in 1eefd13
let expected = [ "+----------------------------+", "| Utf8(\"foo\") || Utf8(\"bar\") |", "+----------------------------+", "| foobar |", "+----------------------------+", ]; let mut expected = ["| logical_plan after topk | TopK: k=3 |", datafusion/datafusion/core/tests/user_defined/user_defined_plan.rs
Lines 217 to 223 in 563da92
"+----------+----------+", "| column_1 | column_2 |", "+----------+----------+", "| andrew | 100 |", "| jorge | 200 |", "| andy | 150 |", "+----------+----------+",
Check the original issue for tips on how to do the switch and examples of completed PRs.
Metadata
Metadata
Assignees
Labels
good first issueGood for newcomersGood for newcomers