Migrate physical plan tests to `insta`

[blaginin]

In #15178, we're switching hard-coded constants in tests to insta.

This issue targets updating physical plan tests (datafusion/physical-plan).

Examples of tests that need to be switched to insta

• datafusion/datafusion/physical-plan/src/aggregates/topk/priority_map.rs

  Lines 133 to 137 in 0e77fb2

  	+----------+--------------+
  	| trace_id | timestamp_ms |
  	+----------+--------------+
  	| 1 | 1 |
  	+----------+--------------+

• datafusion/datafusion/physical-plan/src/unnest.rs

  Lines 1149 to 1159 in 0e77fb2

  	"+---------------------------------+---------------------------------+---------------------------------+",
  	"| col1_unnest_placeholder_depth_1 | col1_unnest_placeholder_depth_2 | col2_unnest_placeholder_depth_1 |",
  	"+---------------------------------+---------------------------------+---------------------------------+",
  	"| [1, 2, 3] | 1 | a |",
  	"| | 2 | b |",
  	"| [4, 5] | 3 | |",
  	"| [1, 2, 3] | | a |",
  	"| | | b |",
  	"| [4, 5] | | |",
  	"| [1, 2, 3] | 4 | a |",
  	"| | 5 | b |",

• datafusion/datafusion/physical-plan/src/aggregates/topk/heap.rs

  Lines 536 to 539 in 0e77fb2

  	val=3 idx=0, bucket=3
  	├── val=1 idx=1, bucket=1
  	└── val=2 idx=2, bucket=2
  	"#;

Check the original issue for tips on how to do the switch and examples of completed PRs.

[Shreyaskr1409]

take

[alamb]

@Shreyaskr1409 are there any more tests to migrate? Or is this ticket complete?

[blaginin]

I think there are a bit more to update, e.g.

datafusion/datafusion/physical-plan/src/windows/bounded_window_agg_exec.rs

Lines 1779 to 1782 in 0ff8984

	let expected_plan = vec![
	"ProjectionExec: expr=[sn@0 as sn, hash@1 as hash, count([Column { name: \"sn\", index: 0 }]) PARTITION BY: [[Column { name: \"hash\", index: 1 }]], ORDER BY: [LexOrdering { inner: [PhysicalSortExpr { expr: Column { name: \"sn\", index: 0 }, options: SortOptions { descending: false, nulls_first: true } }] }]@2 as col_2]",
	" BoundedWindowAggExec: wdw=[count([Column { name: \"sn\", index: 0 }]) PARTITION BY: [[Column { name: \"hash\", index: 1 }]], ORDER BY: [LexOrdering { inner: [PhysicalSortExpr { expr: Column { name: \"sn\", index: 0 }, options: SortOptions { descending: false, nulls_first: true } }] }]: Ok(Field { name: \"count([Column { name: \\\"sn\\\", index: 0 }]) PARTITION BY: [[Column { name: \\\"hash\\\", index: 1 }]], ORDER BY: [LexOrdering { inner: [PhysicalSortExpr { expr: Column { name: \\\"sn\\\", index: 0 }, options: SortOptions { descending: false, nulls_first: true } }] }]\", data_type: Int64, nullable: false, dict_id: 0, dict_is_ordered: false, metadata: {} }), frame: WindowFrame { units: Range, start_bound: CurrentRow, end_bound: Following(UInt64(1)), is_causal: false }], mode=[Linear]",
	" StreamingTableExec: partition_sizes=1, projection=[sn, hash], infinite_source=true, output_ordering=[sn@0 ASC NULLS LAST]",

[Shreyaskr1409]

@Shreyaskr1409 are there any more tests to migrate? Or is this ticket complete?

@alamb tests for sort and windows are still left. They will be the final ones.

[blaginin]

oh, also joins I think (e.g. join_splitted_batch)

[Shreyaskr1409]

oh, also joins I think (e.g. join_splitted_batch)

I will wrap up everything and cross check in next PR. we can proceed any changes to be made there.