-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Closed
Labels
good first issueGood for newcomersGood for newcomers
Description
In #15178, @blaginin outlined a few areas where insta snapshots should replace the use of pre-defined strings. There's a few other files where snapshot tests need to be added that are not included in the original epic. Here are files that still use pre-defined strings for comparison tests:
datafusion/common/src/scalar/mod.rsdatafusion/core/src/execution/context/csv.rsdatafusion/core/src/execution/context/mod.rsdatafusion/core/tests/catalog/memory.rsdatafusion/core/tests/parquet/custom_reader.rsdatafusion/core/tests/parquet/schema_coercion.rsdatafusion/core/tests/parquet/schema.rsdatafusion/core/tests/sql/aggregates.rsdatafusion/core/tests/sql/path_partition.rsdatafusion/core/tests/sql/select.rsdatafusion-cli/src/main.rsdatafusion/physical-optimizer/src/pruning.rs
Most of these files contain 1-3 tests that need to be updated so I don't think it needs to be split into further pieces.
blaginin
Metadata
Metadata
Assignees
Labels
good first issueGood for newcomersGood for newcomers