Fix PREPARE statement tests

[alamb]

@qstommyshu pointed out on #15567 (comment)

That tests that imply they are testing PREPARE are actually not (likely a mistake)

I actually looks to me like it is a mistake in the test 🤔

Perhaps the test should be something like

    let sql = "PREPARE SELECT id, age FROM person WHERE age BETWEEN $1 AND $2";

Instead of

    let sql = "SELECT id, age FROM person WHERE age BETWEEN $1 AND $2";

(maybe we can fix this in a follow on PR -- I will file a ticket)

Originally posted by @alamb in #15567 (comment)

[brayanjuls]

Hey, it's been a long time since I contributed to datafusion, can I work on this one?

[alamb]

Of course!
Thank you @brayanjuls !

[brayanjuls]

take

[qstommyshu]

Hi @brayanjuls,

Welcome back to the community!

I suggest you check the git commit history to uncover the original purpose of these test cases, and then decide whether they should be classified as PREPARE statement tests (note that these tests have their own naming conventions and testing methods).

Happy coding! 🚀

[brayanjuls]

I was investigating this issue and it seems those tests supposed to be for PREPARE statements, as the goal when they were implemented was to test infer types on prepare statements. The issue #4683 and PR #4701. I can go ahead and open a PR to add prepare statements to those test and fix the naming, let me know if you agree with that or if there is something else I am not seeing here.

[qstommyshu]

Got it @brayanjuls , thanks for the research!

I agree with your statement according to the two issues you mentioned. I think you can go ahead a fix those tests now if @alamb doesn't have opposite idea 🙌

[alamb]

I agree -- thanks @brayanjuls and @qstommyshu