-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Closed
Labels
good first issueGood for newcomersGood for newcomers
Description
Description
In #15178, we're switching hard-coded constants in tests to insta.
This issue targets updating tests in pool.rs (datafusion/execution/memory_pool/pool) so that testing long string err messages is easier via snapshot tests.
One example that needs to be switched to insta is
assert_eq!(err, "Resources exhausted: Failed to allocate additional 30.0 B for s4 with 0.0 B already allocated for this reservation - 20.0 B remain available for the total pool"); |
Reference
- https://datafusion.apache.org/contributor-guide/testing.html#snapshot-testing
- PRs linked to original issue will help how to migrate these tests.
alamb and blaginin
Metadata
Metadata
Assignees
Labels
good first issueGood for newcomersGood for newcomers