-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Open
Labels
enhancementNew feature or requestNew feature or request
Description
Is your feature request related to a problem or challenge?
After #15961, in GroupValuesPrimitive
, we store the hash
of group to speed up rehashing.
However, I found the bottleneck of rehashing
is not hash computation, it is actually randomly access to the values
.
So, after experimenting, the better is:
- We directly store the
group value
inmap
- So, during probing we can perform
eq
in-place - And, during rehashing we just perform the cheap hash computation for
group value
But for the large primitives
, it may be still better to store their hashes in map
rather than themselves, otherwise it will make map
too large and lead to possible regression.
Describe the solution you'd like
No response
Describe alternatives you've considered
No response
Additional context
No response
Metadata
Metadata
Assignees
Labels
enhancementNew feature or requestNew feature or request