Skip to content

panic when running regx benchmark #16879

@waynexia

Description

@waynexia

Describe the bug

I'm trying follow up #13364, and encounter a panic with cargo bench --bench regx:

cargo bench --bench regx                                                                                                                 ─╯
   Compiling datafusion-functions v49.0.0 ()
    Finished `bench` profile [optimized] target(s) in 44.01s
     Running benches/regx.rs (target/release/deps/regx-8ff07b6d342ba9ee)
Gnuplot not found, using plotters backend
Benchmarking regexp_count_1000 string: Warming up for 3.0000 s
Warning: Unable to complete 100 samples in 5.0s. You may wish to increase target time to 8.9s, enable flat sampling, or reduce sample count to 50.
regexp_count_1000 string
                        time:   [1.7729 ms 1.7759 ms 1.7790 ms]
Found 3 outliers among 100 measurements (3.00%)
  3 (3.00%) high mild

Benchmarking regexp_count_1000 utf8view: Warming up for 3.0000 s
Warning: Unable to complete 100 samples in 5.0s. You may wish to increase target time to 9.0s, enable flat sampling, or reduce sample count to 50.
regexp_count_1000 utf8view
                        time:   [1.7786 ms 1.7807 ms 1.7830 ms]
Found 4 outliers among 100 measurements (4.00%)
  2 (2.00%) high mild
  2 (2.00%) high severe

regexp_instr_1000 string
                        time:   [2.0744 ms 2.0769 ms 2.0795 ms]

Benchmarking regexp_instr_1000 utf8view: Warming up for 3.0000 s
thread 'main' panicked at ~/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/arrow-array-55.2.0/src/cast.rs:834:33:
primitive array
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

To Reproduce

cargo bench --bench regx

Expected behavior

This benchmark can end without exception

Additional context

BTW, I also noticed the performance of regexp_count_* cases in my environment is way slower than #13364 (comment) (1.77ms vs 875us). Not sure if this is a regression or I need to upgrade my device

Metadata

Metadata

Assignees

Labels

bugSomething isn't working

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions