optimizer panic with certain query(`count(count(x))/y`)

[discord9]

Describe the bug

This bug involve user defined node as leaf node and a slightly complex query, which will panic with index out of bounds: the len is 2 but the index is 2 when trying to optimize this query.

this bug only appear in datafusion="45.0.0", later version(>= 46.0.0) doesn't appear to have this bug, however I fail to found related fixes to it in changelog of 46.0.0, so put it in here just in case it isn't fully fixed.

To Reproduce

Put lib.rs and Cargo.toml to a blank project and can reproduce this pnaic, backtrace also included

backtrace.log
lib.rs.txt
Cargo.toml.txt

Expected behavior

not panic

Additional context

If this bug is clearly fixed in later version, could anyone point me to the pr that fix this? And feel free to close this issue in that case

[2010YOUY01]

Git bisect might help to find the PR that fixes it.

I think it's also a good idea to include the reproducer to the test, if we haven't done that in the fixing PR yet.

[discord9]

Git bisect might help to find the PR that fixes it.

I think it's also a good idea to include the reproducer to the test, if we haven't done that in the fixing PR yet.

it appear that this pr fc2f9dd #14860 "fixed" it, I don't think that's intentional, becuase this pr just default to not add_implicit_group_by_exprs? and even if I set add_implicit_group_by_exprs=true then the bug also wouldn't appear, so I'm still not sure how does this pr fix it

also this pr's add_implicit_group_by_exprs option doesn't seem to persist, i.e: create a builder, set the option, then chain a aggregate then the option will became false again, I think that's another bug maybe

bisect.sh.txt

[discord9]

ok it seems it is not fixed in latest version, reproduce:

lib.rs (2).txt