-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DataFrame TableProvider Circular Reference #2659
Comments
What did you think about this?
|
Sounds good to me - is your idea to add a method like a |
I was thinking more a |
Describe the bug
Currently
DataFrame
implementsTableProvider
allowing it to be registered on aSessionContext
, this will often be the sameSessionContext
from which itsArc<RwLock<SessionState>>
came. For exampleThis will result in a circular reference that will prevent destruction of the SchemaProvider and the DataFrame.
To Reproduce
Inspect code
Expected behavior
It should not be possible to introduce circular dependencies. On a more holistic level, I'm not entirely sure what the purpose of this API is. Perhaps it could be removed and replaced with a combination of
DataFrame::to_logical_plan
andViewTable
(once #2657 is fixed)Additional context
#2658
FYI @yjshen @xudong963
The text was updated successfully, but these errors were encountered: