We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Is your feature request related to a problem or challenge? Please describe what you are trying to do.
Prior to https://github.com/apache/arrow-datafusion/pull/2677/files#diff-0171c6cc11900557bf3bb9bd9fce2a78b8272e7f63ed8259c988ff610334da04L48 there was a trait called FormatReaderOpener. I replaced this with a trait called FormatReader but in hindsight this name is confusing for two reasons:
FormatReaderOpener
FormatReader
FileStream
Describe the solution you'd like
I would like to rename FormatReader to FileOpener and ReaderFuture to FileOpenFuture
FileOpener
ReaderFuture
FileOpenFuture
Describe alternatives you've considered
We could not do this
Additional context
This trait came up in discussion on apache/arrow-rs#2230 and I realised its name was unhelpful
The text was updated successfully, but these errors were encountered:
Rename FileReader to FileOpener (apache#2990)
1cbdf10
Rename FileReader to FileOpener (#2990) (#2991)
193fc3b
Successfully merging a pull request may close this issue.
Is your feature request related to a problem or challenge? Please describe what you are trying to do.
Prior to https://github.com/apache/arrow-datafusion/pull/2677/files#diff-0171c6cc11900557bf3bb9bd9fce2a78b8272e7f63ed8259c988ff610334da04L48 there was a trait called
FormatReaderOpener
. I replaced this with a trait calledFormatReader
but in hindsight this name is confusing for two reasons:FileStream
, i.e. partitionDescribe the solution you'd like
I would like to rename
FormatReader
toFileOpener
andReaderFuture
toFileOpenFuture
Describe alternatives you've considered
We could not do this
Additional context
This trait came up in discussion on apache/arrow-rs#2230 and I realised its name was unhelpful
The text was updated successfully, but these errors were encountered: