Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename FormatReader to FileOpener #2990

Closed
tustvold opened this issue Jul 31, 2022 · 0 comments · Fixed by #2991
Closed

Rename FormatReader to FileOpener #2990

tustvold opened this issue Jul 31, 2022 · 0 comments · Fixed by #2991
Labels
enhancement New feature or request

Comments

@tustvold
Copy link
Contributor

Is your feature request related to a problem or challenge? Please describe what you are trying to do.

Prior to https://github.com/apache/arrow-datafusion/pull/2677/files#diff-0171c6cc11900557bf3bb9bd9fce2a78b8272e7f63ed8259c988ff610334da04L48 there was a trait called FormatReaderOpener. I replaced this with a trait called FormatReader but in hindsight this name is confusing for two reasons:

  • It suggests the trait is involved in reading the file, when in reality it is only responsible for creating the reader
  • It suggests an instance should exist for each format, when in reality they exist for each FileStream, i.e. partition

Describe the solution you'd like

I would like to rename FormatReader to FileOpener and ReaderFuture to FileOpenFuture

Describe alternatives you've considered

We could not do this

Additional context

This trait came up in discussion on apache/arrow-rs#2230 and I realised its name was unhelpful

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant