Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate optimizer passes in optimizer module for better testing #3524

Closed
alamb opened this issue Sep 17, 2022 · 3 comments · Fixed by #3692
Closed

Consolidate optimizer passes in optimizer module for better testing #3524

alamb opened this issue Sep 17, 2022 · 3 comments · Fixed by #3692
Assignees
Labels
enhancement New feature or request

Comments

@alamb
Copy link
Contributor

alamb commented Sep 17, 2022

Is your feature request related to a problem or challenge? Please describe what you are trying to do.
Thinking about the comments from @avantgardnerio on https://github.com/apache/arrow-datafusion/pull/3482/files#r972435250 if/when we want to try rearranging the optimizer passes, we need some way to observe the effect on an overall plan.

Conveniently @andygrove added a test framework for doing so in https://github.com/apache/arrow-datafusion/blob/master/datafusion/optimizer/tests/integration-test.rs

However, while reviewing #3482 I noticed there were two separate lists of optimizer's that were instantiated -- one in an integration test and one in the core module.

This is bad as the lists can get out of sync meaning the tests may not provide as much coverage as we would like

Describe the solution you'd like
I would like the Optimizer pass lists to be in the datafusion-optimizer crate so it can be used by the integration test, and the interface to the overall optimizer to be more well defined

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

@andygrove
Copy link
Member

Thanks @alamb. I had been intending to do some work in this direction as well. I think this sounds great.

@andygrove
Copy link
Member

@alamb I am working on this now because it became important to something that I am working on for this release

@alamb
Copy link
Contributor Author

alamb commented Oct 3, 2022

Outstanding @andygrove -- the biggest issue I hit was extracting the passes from the state.

I am standing by to help review it and get it in quickly 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants