You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
However, while reviewing #3482 I noticed there were two separate lists of optimizer's that were instantiated -- one in an integration test and one in the core module.
This is bad as the lists can get out of sync meaning the tests may not provide as much coverage as we would like
Describe the solution you'd like
I would like the Optimizer pass lists to be in the datafusion-optimizer crate so it can be used by the integration test, and the interface to the overall optimizer to be more well defined
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.
The text was updated successfully, but these errors were encountered:
Is your feature request related to a problem or challenge? Please describe what you are trying to do.
Thinking about the comments from @avantgardnerio on https://github.com/apache/arrow-datafusion/pull/3482/files#r972435250 if/when we want to try rearranging the optimizer passes, we need some way to observe the effect on an overall plan.
Conveniently @andygrove added a test framework for doing so in https://github.com/apache/arrow-datafusion/blob/master/datafusion/optimizer/tests/integration-test.rs
However, while reviewing #3482 I noticed there were two separate lists of optimizer's that were instantiated -- one in an integration test and one in the core module.
This is bad as the lists can get out of sync meaning the tests may not provide as much coverage as we would like
Describe the solution you'd like
I would like the Optimizer pass lists to be in the
datafusion-optimizer
crate so it can be used by the integration test, and the interface to the overall optimizer to be more well definedDescribe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.
The text was updated successfully, but these errors were encountered: