Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make OptimizerConfig a builder style API #3525

Merged
merged 1 commit into from
Sep 19, 2022

Conversation

alamb
Copy link
Contributor

@alamb alamb commented Sep 17, 2022

Which issue does this PR close?

re #3524

Rationale for this change

I am preparing to improve the API between the optimizer and the rest of the system and I want to get the basic pattern established before more major changes

What changes are included in this PR?

This PR moves from modifying public fields to a builder interface for OptimizerConfig

Are there any user-facing changes?

To set execution start time, must use builder interface now

@alamb alamb added the api change Changes the API exposed to users of the crate label Sep 17, 2022
@github-actions github-actions bot added core Core DataFusion crate optimizer Optimizer rules labels Sep 17, 2022
@alamb alamb changed the title MINOR: reduce pub in OptimizerConfig Make OptimizerConfig a builder style API Sep 17, 2022
@alamb alamb marked this pull request as ready for review September 17, 2022 11:39
@codecov-commenter
Copy link

Codecov Report

Merging #3525 (543f8c2) into master (12f047e) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #3525      +/-   ##
==========================================
- Coverage   85.77%   85.76%   -0.01%     
==========================================
  Files         299      299              
  Lines       55334    55336       +2     
==========================================
- Hits        47460    47459       -1     
- Misses       7874     7877       +3     
Impacted Files Coverage Δ
datafusion/core/src/execution/context.rs 79.29% <100.00%> (-0.03%) ⬇️
datafusion/optimizer/src/optimizer.rs 91.66% <100.00%> (+0.75%) ⬆️
datafusion/optimizer/src/simplify_expressions.rs 82.80% <100.00%> (-0.04%) ⬇️
datafusion/optimizer/src/type_coercion.rs 93.56% <100.00%> (ø)
datafusion/expr/src/window_frame.rs 92.43% <0.00%> (-0.85%) ⬇️
datafusion/expr/src/logical_plan/plan.rs 77.68% <0.00%> (-0.34%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@andygrove andygrove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Dandandan Dandandan merged commit 9b22100 into apache:master Sep 19, 2022
@ursabot
Copy link

ursabot commented Sep 19, 2022

Benchmark runs are scheduled for baseline = 86a8236 and contender = 9b22100. 9b22100 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@alamb alamb deleted the alamb/cleanup_integration_test branch August 8, 2023 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api change Changes the API exposed to users of the crate core Core DataFusion crate optimizer Optimizer rules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants