-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement to_unixtime
function
#5568
Comments
@waynexia As a workaround please use #5555
@alamb here we comes again to spark functions, should we support all of them like listed here https://spark.apache.org/docs/3.2.0/api/sql/ even if not all of them compatible with PG |
I don't think we have a strong or consistent story here -- my personal opinion is to focus on postgres compatibility, and only add spark functions for thing that have no postgres equivalent. Given DataFusion has all the extension points already, maybe we could add a separate crate for "spark_extensions" or something 🤔 that way anyone who wanted the spark library functions could have them if they wanted but it could be opt in. |
Thanks for this 👍
Also makes sense to me. We can implement and provide it in a separate crate (something like |
Cross posting link to discussion on spark functions: #5600 |
@alamb I can help with this. Please assign to me |
Thanks @Tangruilin -- you already have several items assigned to you: https://github.com/apache/arrow-datafusion/issues/assigned/Tangruilin If there are some that you are not working on, or we found blockers, perhaps you can unassign yourself so it is clear what the status is. Thank you so much for your help |
I unassign #8824, other issues i am all working on now. |
Signed-off-by: tangruilin <tang.ruilin@foxmail.com>
Signed-off-by: tangruilin <tang.ruilin@foxmail.com>
Signed-off-by: tangruilin <tang.ruilin@foxmail.com>
Signed-off-by: tangruilin <tang.ruilin@foxmail.com>
Signed-off-by: tangruilin <tang.ruilin@foxmail.com>
Signed-off-by: tangruilin <tang.ruilin@foxmail.com>
Signed-off-by: tangruilin <tang.ruilin@foxmail.com>
Signed-off-by: tangruilin <tang.ruilin@foxmail.com>
Signed-off-by: tangruilin <tang.ruilin@foxmail.com>
Signed-off-by: tangruilin <tang.ruilin@foxmail.com>
Signed-off-by: tangruilin <tang.ruilin@foxmail.com>
Signed-off-by: tangruilin <tang.ruilin@foxmail.com>
* [task #5568] add_to_unixtime_function Signed-off-by: tangruilin <tang.ruilin@foxmail.com> * Fix clippy --------- Signed-off-by: tangruilin <tang.ruilin@foxmail.com> Co-authored-by: Andrew Lamb <andrew@nerdnetworks.org>
Is your feature request related to a problem or challenge? Please describe what you are trying to do.
Like
from_unixtime
in #2871,to_unixtime
is sometimes also useful when compared with other data that is in UNIX timestamp format or don't want to care about the timezone.Describe the solution you'd like
Take
to_unix_timestamp
in spark as example:Describe alternatives you've considered
Additional context
The text was updated successfully, but these errors were encountered: