Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Followup tasks for nanvl #7310

Closed
sarutak opened this issue Aug 16, 2023 · 0 comments · Fixed by #7311
Closed

Followup tasks for nanvl #7310

sarutak opened this issue Aug 16, 2023 · 0 comments · Fixed by #7311
Labels
bug Something isn't working

Comments

@sarutak
Copy link
Member

sarutak commented Aug 16, 2023

Describe the bug

I added nanvl in #7171 but some followup tasks needed.
One is adding an entry to the function list table in user-guide/expressions.md for nanvl.
Another is modifying the error message in tests newly added to math_expressions.rs.

--- a/datafusion/physical-expr/src/math_expressions.rs
+++ b/datafusion/physical-expr/src/math_expressions.rs
@@ -1057,9 +1057,9 @@ mod tests {
             Arc::new(Float64Array::from(vec![5.0, 6.0, f64::NAN, f64::NAN])), // x
         ];
 
-        let result = nanvl(&args).expect("failed to initialize function atan2");
+        let result = nanvl(&args).expect("failed to initialize function nanvl");
         let floats =
-            as_float64_array(&result).expect("failed to initialize function atan2");
+            as_float64_array(&result).expect("failed to initialize function nanvl");
 
         assert_eq!(floats.len(), 4);
         assert_eq!(floats.value(0), 1.0);
@@ -1075,9 +1075,9 @@ mod tests {
             Arc::new(Float32Array::from(vec![5.0, 6.0, f32::NAN, f32::NAN])), // x
         ];
 
-        let result = nanvl(&args).expect("failed to initialize function atan2");
+        let result = nanvl(&args).expect("failed to initialize function nanvl");
         let floats =
-            as_float32_array(&result).expect("failed to initialize function atan2");
+            as_float32_array(&result).expect("failed to initialize function nanvl");

To Reproduce

No response

Expected behavior

No response

Additional context

No response

@sarutak sarutak added the bug Something isn't working label Aug 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant