Add nanvl builtin function #7171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
logical-expr
alamb
approved these changes
Aug 1, 2023
There was a problem hiding this comment.
This looks great -- thank you very much @sarutak 🙏
Can you please also add an entry to the user guide about this function https://github.com/apache/arrow-datafusion/blob/main/docs/source/user-guide/sql/scalar_functions.md#atan2 ?
We don't yet have automated documentation I am afraid (#3092)
|
|
||
| # nanvl | ||
| query RRR | ||
| SELECT nanvl(asin(10), 1.0), nanvl(1.0, 2.0), nanvl(asin(10), asin(10)) |
There was a problem hiding this comment.
👍 for testing when both args are NAN
|
@alamb |
alamb
approved these changes
Aug 2, 2023
This was referenced Aug 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #7170
Rationale for this change
I propose to add
nanvlbuiltin function which is provided by some RDBMS.nanvl(x, y)returnsxifxis notNaNotherwise returnsy.It could be convenience to handle missing data.
What changes are included in this PR?
nullvlis added as a math builtin function.Are these changes tested?
Added new tests.
Are there any user-facing changes?
New builtin function is added but it doesn't break compatibility.