Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove ScalarValue Ord / PartialOrd #7517

Open
tustvold opened this issue Sep 10, 2023 · 0 comments
Open

Remove ScalarValue Ord / PartialOrd #7517

tustvold opened this issue Sep 10, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@tustvold
Copy link
Contributor

Is your feature request related to a problem or challenge?

The performance of sorting ScalarValue directly will be exceptionally poor, especially when compared to vectorised approaches operating on arrays or rows, and having separate mechanisms introduces opportunity for inconsistency.

Describe the solution you'd like

Remove PartialOrd and Ord from ScalarValue

Describe alternatives you've considered

No response

Additional context

#7353 #7352 both track using ArrayRef within ScalarValue which this would relate to
@tustvold tustvold added the enhancement New feature or request label Sep 10, 2023
@tustvold tustvold mentioned this issue Sep 10, 2023
Open
tustvold added a commit to tustvold/arrow-datafusion that referenced this issue Sep 10, 2023
@tustvold
Simplify ScalarValue::distance (apache#7517)
519cb89
tustvold added a commit to tustvold/arrow-datafusion that referenced this issue Sep 10, 2023
@tustvold
Simplify ScalarValue::distance (apache#7517)
2179609
tustvold added a commit to tustvold/arrow-datafusion that referenced this issue Sep 10, 2023
@tustvold
Simplify ScalarValue::distance (apache#7517)
99fa364
@tustvold tustvold mentioned this issue Sep 10, 2023
Merged
tustvold added a commit to tustvold/arrow-datafusion that referenced this issue Sep 10, 2023
@tustvold
Simplify ScalarValue::distance (apache#7517)
6fd3431
tustvold added a commit that referenced this issue Sep 11, 2023
@tustvold
Simplify ScalarValue::distance (#7517) (#7519)
4abae3b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tustvold