-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port tests in select.rs
to sqllogictest
#8213
Comments
i want to try this. 😄 |
This one I think is still a good first issue / maybe even covered by existing tests |
@alamb maybe this can assign to me |
Here it create a column with struct, but i do not know how to create it by sql |
|
Signed-off-by: tangruilin <tang.ruilin@foxmail.com>
I think you can use the |
Signed-off-by: tangruilin <tang.ruilin@foxmail.com>
Signed-off-by: tangruilin <tang.ruilin@foxmail.com>
Signed-off-by: tangruilin <tang.ruilin@foxmail.com>
Hi both - @Tangruilin seems like we we're working independently on the topic 😮 I had raised two PRs previously but seems they remained unnoticed. Guess we should try to consolidate into a single PR, feel free to take over whatever you're missing currently from #8953 and #8939 and integrate into yours if that's ok with you as well. In #8939 you will find how I implemented the structs. |
I have already sloved the problem of struct in my CR. |
Signed-off-by: tangruilin <tang.ruilin@foxmail.com>
Maybe We can use my CR? |
Signed-off-by: tangruilin <tang.ruilin@foxmail.com>
Signed-off-by: tangruilin <tang.ruilin@foxmail.com>
Signed-off-by: tangruilin <tang.ruilin@foxmail.com>
Signed-off-by: tangruilin <tang.ruilin@foxmail.com>
Yes sounds good! |
Yes, sorry -- I am backed up on reviews. I am hoping other committers can find more time to help. I am working to try and get the backlog down |
* [task #8213]Part of Port tests in select.rs to sqllogictest Signed-off-by: tangruilin <tang.ruilin@foxmail.com> * test large strings as well * Restore parameter tests * make test deterministic --------- Signed-off-by: tangruilin <tang.ruilin@foxmail.com> Co-authored-by: Andrew Lamb <andrew@nerdnetworks.org>
Is your feature request related to a problem or challenge?
Part of #6195. We are trying to
Part of doing so is having a single location for most test coverage so new tests can be added easily and people can follow the existing patterns easily
Describe the solution you'd like
Port the tests in https://github.com/apache/arrow-datafusion/blob/main/datafusion/core/tests/sql/select.rs to
select.slt
in https://github.com/apache/arrow-datafusion/tree/main/datafusion/sqllogictest/test_filesNote you can create catalogs and schema via SQL now
Catalogs: https://arrow.apache.org/datafusion/user-guide/sql/ddl.html#create-database
Schema: https://arrow.apache.org/datafusion/user-guide/sql/ddl.html#create-schema
Notes:
Describe alternatives you've considered
No response
Additional context
I think these are good first issues as they teach the contributor about the DataFusion codebase and tests, as well as see the end user apis in practice.
The text was updated successfully, but these errors were encountered: