Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport to 37: Reduce DataFrame stack size and fix large futures warnings #10123

Merged
merged 1 commit into from
Apr 18, 2024

Conversation

sergiimk
Copy link
Contributor

Note: this targets branch-37, NOT main.

Which issue does this PR close?

Part of 37 maintenance release #9904

Rationale for this change

Backport fixes for stack overflowing due to large futures.

What changes are included in this PR?

Backport #10033, fix for #9893 to branch-37

Are these changes tested?

Covered by existing tests.

Are there any user-facing changes?

No API changes.

@github-actions github-actions bot added the core Core DataFusion crate label Apr 17, 2024
@sergiimk sergiimk changed the title Backport: Lighten DataFrame size and fix large futures warnings Backport to 37: Lighten DataFrame size and fix large futures warnings Apr 17, 2024
Copy link
Member

@andygrove andygrove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sergiimk

Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me -- thank you @sergiimk

@alamb alamb changed the title Backport to 37: Lighten DataFrame size and fix large futures warnings Backport to 37: Reduce DataFrame stack size and fix large futures warnings Apr 18, 2024
@alamb alamb merged commit d4eb72c into apache:branch-37 Apr 18, 2024
25 checks passed
@sergiimk sergiimk deleted the backport-10033-large-futures branch April 18, 2024 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Core DataFusion crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants