Move create_physical_expr to phy-expr-common #1

datafusion/physical-expr-common/Cargo.toml

@@ -39,3 +39,4 @@ path = "src/lib.rs"
 arrow = { workspace = true }
 datafusion-common = { workspace = true, default-features = true }
 datafusion-expr = { workspace = true }
+paste = "^1.0"

datafusion/physical-expr/src/expressions/binary.rs → datafusion/physical-expr-common/src/expressions/binary.rs

@@ -23,8 +23,8 @@ use std::{any::Any, sync::Arc};
 use crate::expressions::datum::{apply, apply_cmp};
 use crate::intervals::cp_solver::{propagate_arithmetic, propagate_comparison};
 use crate::physical_expr::down_cast_any_ref;
+use crate::physical_expr::PhysicalExpr;
 use crate::sort_properties::SortProperties;
-use crate::PhysicalExpr;
 
 use arrow::array::*;
 use arrow::compute::kernels::boolean::{and_kleene, not, or_kleene};
@@ -622,8 +622,13 @@ pub fn binary(
 #[cfg(test)]
 mod tests {
     use super::*;
-    use crate::expressions::{col, lit, try_cast, Literal};
-    use datafusion_common::plan_datafusion_err;
+    use crate::expressions::column::col;
+    use crate::expressions::literal::{lit, Literal};
+    use crate::expressions::try_cast::try_cast;
+    use arrow::datatypes::{
+        ArrowNumericType, Decimal128Type, Field, Int32Type, SchemaRef,
+    };
+    use datafusion_common::{plan_datafusion_err, Result};
     use datafusion_expr::type_coercion::binary::get_input_types;
 
     /// Performs a binary operation, applying any type coercion necessary

datafusion/physical-expr/src/expressions/datum.rs → datafusion/physical-expr-common/src/expressions/datum.rs

@@ -15,17 +15,17 @@
 // specific language governing permissions and limitations
 // under the License.
 
+use arrow::array::BooleanArray;
 use arrow::array::{ArrayRef, Datum};
 use arrow::error::ArrowError;
-use arrow_array::BooleanArray;
 use datafusion_common::{Result, ScalarValue};
 use datafusion_expr::ColumnarValue;
 use std::sync::Arc;
 
 /// Applies a binary [`Datum`] kernel `f` to `lhs` and `rhs`
 ///
 /// This maps arrow-rs' [`Datum`] kernels to DataFusion's [`ColumnarValue`] abstraction
-pub(crate) fn apply(
+pub fn apply(
     lhs: &ColumnarValue,
     rhs: &ColumnarValue,
     f: impl Fn(&dyn Datum, &dyn Datum) -> Result<ArrayRef, ArrowError>,
@@ -49,7 +49,7 @@ pub(crate) fn apply(
 }
 
 /// Applies a binary [`Datum`] comparison kernel `f` to `lhs` and `rhs`
-pub(crate) fn apply_cmp(
+pub fn apply_cmp(
     lhs: &ColumnarValue,
     rhs: &ColumnarValue,
     f: impl Fn(&dyn Datum, &dyn Datum) -> Result<BooleanArray, ArrowError>,

datafusion/physical-expr/src/expressions/literal.rs → datafusion/physical-expr-common/src/expressions/literal.rs

@@ -22,8 +22,8 @@ use std::hash::{Hash, Hasher};
 use std::sync::Arc;
 
 use crate::physical_expr::down_cast_any_ref;
+use crate::physical_expr::PhysicalExpr;
 use crate::sort_properties::SortProperties;
-use crate::PhysicalExpr;
 
 use arrow::{
     datatypes::{DataType, Schema},

datafusion/physical-expr-common/src/expressions/mod.rs

@@ -15,4 +15,11 @@
 // specific language governing permissions and limitations
 // under the License.
 
+//! Defines physical expressions that can evaluated at runtime during query execution
+
+#[macro_use]
+pub mod binary;
 pub mod column;
+pub mod datum;
+pub mod literal;
+pub mod try_cast;

datafusion/physical-expr/src/expressions/try_cast.rs → datafusion/physical-expr-common/src/expressions/try_cast.rs

@@ -21,7 +21,7 @@ use std::hash::{Hash, Hasher};
 use std::sync::Arc;
 
 use crate::physical_expr::down_cast_any_ref;
-use crate::PhysicalExpr;
+use crate::physical_expr::PhysicalExpr;
 use arrow::compute;
 use arrow::compute::{cast_with_options, CastOptions};
 use arrow::datatypes::{DataType, Schema};
@@ -148,7 +148,7 @@ pub fn try_cast(
 #[cfg(test)]
 mod tests {
     use super::*;
-    use crate::expressions::col;
+    use crate::expressions::column::col;
     use arrow::array::{
         Decimal128Array, Decimal128Builder, StringArray, Time64NanosecondArray,
     };