Add tests that random() and uuid() produce unique values for each row
#10248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jefffrey
approved these changes
Apr 26, 2024
And good luck reproducing it 😆 (but seriously I think the chance of infrastructure failures are far more likely) |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #10247
Rationale for this change
We have a gap in test coverage
All the tests passed, but we almost broke this behavior, but caught it in review #10193 (comment)
What changes are included in this PR?
randomanduuidNote I also verified that these tests fail at 864d197 (part of #10193 which almost introduced a bug)
Are these changes tested?
Only tests
Are there any user-facing changes?