Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Null aware anti join by HashJoin #10584

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

viirya
Copy link
Member

@viirya viirya commented May 20, 2024

Which issue does this PR close?

Closes #10583.

Rationale for this change

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

@viirya viirya marked this pull request as draft May 20, 2024 17:56
@github-actions github-actions bot added the sqllogictest SQL Logic Tests (.slt) label May 20, 2024
@viirya
Copy link
Member Author

viirya commented May 20, 2024

Added the test case first. I will find some time to work on the fix.

SELECT * FROM test_table t1 LEFT ANTI JOIN test_table t2 ON t1.c1 = t2.c2
----
4 NULL
NULL 0
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently LeftAnti join returns incorrect results.

@viirya viirya force-pushed the hash_join_left_anti_null branch from fe04729 to e6bc050 Compare May 20, 2024 23:28
@viirya viirya force-pushed the hash_join_left_anti_null branch from e6bc050 to 3839398 Compare May 21, 2024 05:48
@viirya viirya changed the title HashJoin LeftAnti Join should handle nulls correctly DataFusion HashJoin LeftAnti support Null aware anti join May 21, 2024
@viirya viirya changed the title DataFusion HashJoin LeftAnti support Null aware anti join Support Null aware anti join by HashJoin May 21, 2024
Copy link

Thank you for your contribution. Unfortunately, this pull request is stale because it has been open 60 days with no activity. Please remove the stale label or comment or this will be closed in 7 days.

@github-actions github-actions bot added the Stale PR has not had any activity for some time label Aug 14, 2024
@viirya viirya removed the Stale PR has not had any activity for some time label Aug 14, 2024
Copy link

Thank you for your contribution. Unfortunately, this pull request is stale because it has been open 60 days with no activity. Please remove the stale label or comment or this will be closed in 7 days.

@github-actions github-actions bot added the Stale PR has not had any activity for some time label Oct 14, 2024
@github-actions github-actions bot closed this Oct 21, 2024
@viirya viirya reopened this Oct 21, 2024
@viirya viirya removed the Stale PR has not had any activity for some time label Oct 21, 2024
Copy link

Thank you for your contribution. Unfortunately, this pull request is stale because it has been open 60 days with no activity. Please remove the stale label or comment or this will be closed in 7 days.

@github-actions github-actions bot added the Stale PR has not had any activity for some time label Dec 21, 2024
@viirya viirya removed the Stale PR has not had any activity for some time label Dec 21, 2024
Copy link

Thank you for your contribution. Unfortunately, this pull request is stale because it has been open 60 days with no activity. Please remove the stale label or comment or this will be closed in 7 days.

@github-actions github-actions bot added the Stale PR has not had any activity for some time label Feb 20, 2025
@viirya viirya removed the Stale PR has not had any activity for some time label Feb 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sqllogictest SQL Logic Tests (.slt)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DataFusion HashJoin LeftAnti doesn't support null aware anti join
1 participant