Push down filter as table partition list prefix #10693
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
optimizer
houqp
force-pushed
the
qp_upstream_partition_filter
branch
2 times, most recently
from
7278824
to
b47e1e9
Compare
github-actions
bot
removed
optimizer
houqp
force-pushed
the
qp_upstream_partition_filter
branch
from
b47e1e9
to
679ab29
Compare
alamb
approved these changes
May 29, 2024
Comment on lines
784
to
787
| &[Expr::and( | ||
| Expr::eq(col("a"), lit("foo")), | ||
| Expr::eq(col("b"), lit("bar")), | ||
| )], |
There was a problem hiding this comment.
You can write this kind of expression more simply like col("a").eq(lit("foo")).and(col("b").eq(lit("bar"))) though maybe what you have is more readable
There was a problem hiding this comment.
the eq helper improves readability, i applied that to all tests. i do agree with you that the .and helper makes the expression less readable.
| // no prefix when filter is empty | ||
| assert_eq!(evaluate_partition_prefix(partitions, &[]), None); | ||
|
|
||
| // b=foo results in no prefix because a is not restricted |
There was a problem hiding this comment.
I recommend adding some other tests:
- another negative test like
a < 5to cover the fact that only=predicates are allowed - A test with the literal and constant swapped (
foo = a)
houqp
force-pushed
the
qp_upstream_partition_filter
branch
from
679ab29
to
1a29bb5
Compare
This was referenced May 31, 2024
findepi
pushed a commit
to findepi/datafusion
that referenced
this pull request
Jul 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
When applicable, table partition listing can be optimized by deriving a listing prefix based on literals provided in the filter predicates.
For a selected table with many partitions, this change reduces query time from minutes to 200ms.
What changes are included in this PR?
stacked on top of Display date32/64 in YYYY-MM-DD format #10691. please review that PR first.evaluate_partition_prefixfunction to derive a listing prefix based on filter predicates and table partitions.list_partitionsextended to take an optional prefix argument.Are these changes tested?
Tested with unit tests.
Are there any user-facing changes?
No