Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MINOR: use workspace deps in proto-common (upgrade object store dependency) #10848

Merged
merged 1 commit into from
Jun 10, 2024

Conversation

waynexia
Copy link
Member

Which issue does this PR close?

Resolve #10765 (comment)

Rationale for this change

Some deps in proto-common are not inherited from the workspace, bringing inconsistency after bump dependencies.

What changes are included in this PR?

Refactor proto-common's Cargo deps to inherit common deps from workspace.

Are these changes tested?

Are there any user-facing changes?

Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
@alamb
Copy link
Contributor

alamb commented Jun 10, 2024

Thank you @waynexia

@alamb alamb changed the title MINOR: use workspace deps in proto-common MINOR: use workspace deps in proto-common (upgrade object store dependency) Jun 10, 2024
@alamb alamb merged commit f6450e2 into apache:main Jun 10, 2024
25 checks passed
@waynexia waynexia deleted the sanitize-deps branch June 10, 2024 14:55
findepi pushed a commit to findepi/datafusion that referenced this pull request Jul 16, 2024
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
mpurins-coralogix pushed a commit to coralogix/arrow-datafusion that referenced this pull request Aug 14, 2024
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
mpurins-coralogix added a commit to coralogix/arrow-datafusion that referenced this pull request Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants