Make arrow_cast::parse_data_type public
#11251
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samuelcolvin
changed the title
arrow_cast::parse_data_type publicarrow_cast::parse_data_type public
|
I've assuming this will be refused due to the outstanding issue, so I've implemented apache/arrow-rs#5994. |
|
Closing in favor of apache/arrow-rs#5994. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Until apache/arrow-rs#3821 gets closed and
parse_data_typegets moved to arrow-rs, it would be extremely helpful for us ifparse_data_typewas public.Currently we have some home rolled logic for inferring arrow datatypes from strings when we define schema in toml files.
What changes are included in this PR?
Is now public
Are these changes tested?
I tried to add a test for this specifically in
datafusion/functions/src/core/arrow_cast.rsbut it works regardless of whether the function is public. Let me know if you'd like me to add a test somewhere else?Are there any user-facing changes?
Is now public