Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to arrow 52.1.0 (and fix clippy issues on main) #11302

Merged
merged 2 commits into from
Jul 6, 2024

Conversation

alamb
Copy link
Contributor

@alamb alamb commented Jul 6, 2024

Which issue does this PR close?

closes #11202

Rationale for this change

https://crates.io/crates/arrow/52.1.0 was released an hour ago and causes clippy to start failing

Example CI failure: https://github.com/apache/datafusion/actions/runs/9818545016/job/27111235864?pr=11290

error: using `clone` on type `TimeUnit` which implements the `Copy` trait
    --> datafusion/expr/src/type_coercion/binary.rs:1079:21
     |
1079 |                     l.clone()
     |                     ^^^^^^^^^ help: try dereferencing it: `*l`
     |
     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
     = note: `-D clippy::clone-on-copy` implied by `-D warnings`
     = help: to override `-D warnings` add `#[allow(clippy::clone_on_copy)]`

What changes are included in this PR?

Update to the arrow 52.1.0 release, and fix clippy issues

Are these changes tested?

Yes by CI

Are there any user-facing changes?

Updated library

@github-actions github-actions bot added the logical-expr Logical plan and expressions label Jul 6, 2024
@alamb alamb marked this pull request as ready for review July 6, 2024 11:06
Copy link
Member

@andygrove andygrove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @alamb

@andygrove andygrove merged commit 08c5345 into apache:main Jul 6, 2024
25 checks passed
@alamb alamb deleted the alamb/arrow_upgrade branch July 7, 2024 12:03
findepi pushed a commit to findepi/datafusion that referenced this pull request Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
logical-expr Logical plan and expressions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants