Enable SortMergeJoin LeftAnti filtered fuzz tests #11535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
comphead
commented
Jul 18, 2024
| @@ -217,6 +225,7 @@ async fn test_semi_join_1k() { | |||
|
|
|||
| #[tokio::test] | |||
| async fn test_semi_join_1k_filtered() { | |||
| // NLJ vs HJ gives wrong result | |||
There was a problem hiding this comment.
The HashJoin and NestedLoop Join gives different results for filtered joins fuzz tests.
In the same time HashJoin and SortMergeJoin results are correct.
Need to triage what is going on.
There was a problem hiding this comment.
Could you add a reference to the issue with the comment here
andygrove
reviewed
Jul 18, 2024
| #[tokio::test] | ||
| async fn test_anti_join_1k_filtered() { | ||
| // NLJ vs HJ gives wrong result |
There was a problem hiding this comment.
Can you file an issue for this and reference it here?
andygrove
approved these changes
Jul 18, 2024
viirya
approved these changes
Jul 18, 2024
|
Thanks everyone for get this reviewed |
|
FYI I have seen this test fail now a few times on unrelated PRs: #11555 |
Lordworms
pushed a commit
to Lordworms/arrow-datafusion
that referenced
this pull request
Jul 23, 2024
* Enable LeftAnti filtered fuzz tests * Enable LeftAnti filtered fuzz tests. Add git reference
wiedld
pushed a commit
to influxdata/arrow-datafusion
that referenced
this pull request
Jul 31, 2024
* Enable LeftAnti filtered fuzz tests * Enable LeftAnti filtered fuzz tests. Add git reference
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #10872.
Rationale for this change
Fixed the fuzz test, previously the filter was not set up correctly
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?