Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement physical plan serialization for csv COPY plans , add as_any, Debug to FileFormatFactory #11588

Merged
merged 4 commits into from
Jul 23, 2024
Merged

Implement physical plan serialization for csv COPY plans , add as_any, Debug to FileFormatFactory #11588

merged 4 commits into from
Jul 23, 2024

Conversation

Lordworms
Copy link
Contributor

part of #11150

Which issue does this PR close?

Closes #.

Rationale for this change

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

@github-actions github-actions bot added the core Core DataFusion crate label Jul 21, 2024
@Lordworms
Copy link
Contributor Author

will add the json, avro, parquet format in next PR

@alamb alamb changed the title Implement physical plan serialization for csv COPY plans Implement physical plan serialization for csv COPY plans , add as_any to FileFormatFactory Jul 22, 2024
@alamb alamb added the api change Changes the API exposed to users of the crate label Jul 22, 2024
@alamb alamb changed the title Implement physical plan serialization for csv COPY plans , add as_any to FileFormatFactory Implement physical plan serialization for csv COPY plans , add as_any, Debug to FileFormatFactory Jul 22, 2024
alamb
alamb approved these changes Jul 22, 2024
View reviewed changes
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me -- thank you @Lordworms

cc @devinjdangelo

datafusion/core/src/datasource/file_format/mod.rs Show resolved Hide resolved
datafusion/core/src/datasource/file_format/mod.rs Outdated Show resolved Hide resolved
@github-actions github-actions bot added documentation Improvements or additions to documentation sql SQL Planner development-process Related to development process of DataFusion logical-expr Logical plan and expressions physical-expr Physical Expressions optimizer Optimizer rules sqllogictest SQL Logic Tests (.slt) substrait labels Jul 23, 2024
@github-actions github-actions bot removed documentation Improvements or additions to documentation sql SQL Planner development-process Related to development process of DataFusion logical-expr Logical plan and expressions physical-expr Physical Expressions optimizer Optimizer rules sqllogictest SQL Logic Tests (.slt) substrait labels Jul 23, 2024
@Lordworms
Copy link
Contributor Author

The fuzz test failed seems to be unrelated to this PR

@alamb
Copy link
Contributor

alamb commented Jul 23, 2024

The fuzz test failed seems to be unrelated to this PR

I restarted the CI check. I think the failure is #11555 -- the test was disabled tomorrow while we investigate

@alamb alamb merged commit 6d8bd2c into apache:main Jul 23, 2024
24 checks passed
@alamb
Copy link
Contributor

alamb commented Jul 23, 2024

Thanks (again) @Lordworms

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alamb alamb alamb approved these changes

Assignees
No one assigned
Labels
api change Changes the API exposed to users of the crate core Core DataFusion crate
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Lordworms @alamb