Remove ArrayAgg Builtin in favor of UDF #11611
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jayzhan211 <jayzhan211@gmail.com>
github-actions
bot
added
logical-expr
jayzhan211
commented
Jul 23, 2024
| if reverse_udf.name() == "ARRAY_AGG" { | ||
| // If the function is changed, we need to reverse order_by clause as well | ||
| // i.e. First(a order by b asc null first) -> Last(a order by b desc null last) | ||
| if self.fun().name() == reverse_udf.name() { |
There was a problem hiding this comment.
I guess name checking is enough for now.
Introduce supports_rewrite_order_by for AggregateUDFImpl might add additional complexity without benefit.
There was a problem hiding this comment.
I think it would be good to eventually move this to a method in https://github.com/apache/datafusion/pull/11611 though I agree this is good for now. Maybe we can file a ticket to track
alamb
approved these changes
Jul 23, 2024
| if reverse_udf.name() == "ARRAY_AGG" { | ||
| // If the function is changed, we need to reverse order_by clause as well | ||
| // i.e. First(a order by b asc null first) -> Last(a order by b desc null last) | ||
| if self.fun().name() == reverse_udf.name() { |
There was a problem hiding this comment.
I think it would be good to eventually move this to a method in https://github.com/apache/datafusion/pull/11611 though I agree this is good for now. Maybe we can file a ticket to track
| @@ -37,8 +36,6 @@ pub enum AggregateFunction { | |||
| Min, | |||
| /// Maximum | |||
| Max, | |||
| /// Aggregation into an array | |||
alamb
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #.
Part of #8708
Rationale for this change
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?