(WIP) Cleanup: remove redundant constant evaluation in Simplifier
#1164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Will do this as a follow on to #1164. |
andygrove
added a commit
to andygrove/datafusion
that referenced
this pull request
Jan 31, 2025
…e#1164) * Move string kernels and expressions to spark-expr crate * remove unused hash kernel * remove unused dependencies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Builds on #1163 and #1153 so review them first
re #1070
Rationale for this change
This cleans up the final redundant logic out of constant_folding.rs and into
ConstEvaluatorWhat changes are included in this PR?
remove redundant code in
Simplifierthat is covered byConstEvaluatorAre there any user-facing changes?
No