Use AccumulatorArgs::is_reversed in NthValueAgg
#11669
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcsherin
changed the title
AccumulatorArgs::is_reversed in NthValueAgg
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #11668.
Rationale for this change
The
AccmulatorArgs::is_reversedwas introduced in #11564 for indicating that the aggregation order has been reversed. The existing implementation ofNthValueAgginstead uses internal state.I believe it makes sense to use the new
is_reversedfield with the added benefit of deleting some code fromNthValueAgg.What changes are included in this PR?
Refactors
NthValueAggto useAccumulatorArgs::is_reversed.Are these changes tested?
This is a simple refactor of existing code, so only existing checks against CI.
Are there any user-facing changes?
Yes. A minor fix to doc comment for
AggregateFunctionExpr::is_reversed.